Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: expose micromatch's dot-File option #870

Closed
c-vetter opened this issue Jul 15, 2019 · 5 comments
Closed

Feature Request: expose micromatch's dot-File option #870

c-vetter opened this issue Jul 15, 2019 · 5 comments

Comments

@c-vetter
Copy link

As noted in #577, chokidar does not currently expose an option to watch files/directories starting with dots. Since I need the watch behaviour, simply using micromatch directly is not a good option.

Would be nice to have this option exposed.

@paulmillr
Copy link
Owner

Yeah, it's a surprise to me this is the default behavior. We should probably hardcode it. See micromatch/picomatch#25

@jonschlinkert
Copy link

Yeah, it's a surprise to me this is the default behavior

This is the default behavior in every globbing lib I've seen, but that doesn't mean we can't change it. I'd be open to it if it makes sense.

However, since this is the first issue I've ever seen an any of our globbing libs about this, my gut tells me that matching dotfiles by default will cause more confusion for more people.

Since this would be a breaking change, and it would cause existing glob patterns to return different results, maybe we should let this sit and get more feedback before we change anything?

@orty
Copy link

orty commented Sep 9, 2019

Hi,

This is also a feature I would like to see released. I am building a generic backup tool which listens to changes in a text file containing any kind of paths (to files or to dirs/**/*) and back them up in a centralized archive when they change.

So far, I was not able to successfully watch changes recursively in paths which could contain dotted folders.

Thx

@paulmillr
Copy link
Owner

We will release 3.1 with the option enabled soon.

@orty
Copy link

orty commented Sep 17, 2019

Hi,

Seems to be working way better now ! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants