Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable repeated notifications of "Connection to Pico lost" #193

Closed
sgbaird opened this issue Jan 29, 2024 · 6 comments · Fixed by #205
Closed

Ability to disable repeated notifications of "Connection to Pico lost" #193

sgbaird opened this issue Jan 29, 2024 · 6 comments · Fixed by #205
Assignees
Labels
enhancement New feature or request

Comments

@sgbaird
Copy link
Contributor

sgbaird commented Jan 29, 2024

Feature Request 🚀

Is your feature request related to a problem? Please describe.

The following message (bottom-right corner) pops up over and over again when I don't have a Pico W connected. The message is pretty distracting, especially since it "pops up" again, instead of just staying there. If I click "X" on a notification, it just comes back again.

image

Even when I click "Turn notifications off" it still pops up with the message:

image

Describe the solution you'd like

Create an option to disable these notifications/popups. In my case, it's pretty clear whether the Pico W is connected vs. disconnected based on the status bar icon, though I see how it would be generally useful to know if it has disconnected when that isn't the user's intention.

Describe alternatives you've considered

I've ended up disabling and reenabling the entire extension on a per-workspace basis.

@sgbaird sgbaird added the enhancement New feature or request label Jan 29, 2024
@paulober paulober self-assigned this Jan 30, 2024
@vbakke
Copy link

vbakke commented Feb 13, 2024

I agree. This is a really annoying repetitive warning. One warning when I disconnect the cable is fine. But it reappears every 7.5 seconds.

I use MicroPico v3.7.4 on a Windows VS Code 1.86.1

@sgbaird
Copy link
Contributor Author

sgbaird commented Feb 13, 2024

@vbakke Since I'm still doing a fair bit of development off-and-on with the Pico W, I've decided to just connect one to make the warning go away.. 🫠

@vbakke
Copy link

vbakke commented Feb 14, 2024

One way of solving it, I guess.

Hard for me to know if the problem (or the solution) lies in MicroPython (blame code), or if it is the PyBoard's Pyboardrunner firing onExit non-stop.

Hopefulle someone else managed to find the cause. 🙏

@migs35323
Copy link

Just installed this extension, and come to look for this, when i open code it shows multiple warnings of the connection lost, i believe there should be improvements on this, it makes vscode a bit slower and awkard in general when trying to use other unrelated projects

@paulober
Copy link
Owner

These unnecessary notifications should be fixed with the next patch. Thanks for the feedback.

@vbakke
Copy link

vbakke commented Feb 26, 2024

Looks good when I tested just now. :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants