Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for messages file #7

Closed
pavelkeyzik opened this issue Oct 17, 2022 · 2 comments · Fixed by #8
Closed

Add unit tests for messages file #7

pavelkeyzik opened this issue Oct 17, 2022 · 2 comments · Fixed by #8
Assignees
@batunpc
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@pavelkeyzik
Copy link
Owner

What

We want to add unit tests to our list of the messages

Why

To get rid of duplications, or to ignore unwanted messages like "LGTM"

Eng details

Task 1: Add unit test to make sure all messages are unique.

  • Good job and GOOD JOB should fail as messages are the same
  • Great job 👍 and Great job 💯 should fail as we should ignore emojis (Note: we should also remove this duplication in messages.js file, as at the moment we have that issue)
  • Good job and Great job should have success message, as messages are unique

Task 2: Add unit test to make sure we don't have LGTM message
@pavelkeyzik pavelkeyzik added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 17, 2022
@batunpc
Copy link
Contributor

batunpc commented Oct 17, 2022

Hello @pavelkeyzik I will take a look! 💯

@pavelkeyzik
Copy link
Owner Author

Thanks @batunpc I'll assign this to you 😊

@batunpc batunpc mentioned this issue Oct 17, 2022
Merged
3 tasks
@pavelkeyzik pavelkeyzik linked a pull request Oct 18, 2022 that will close this issue
Unit tests for messages #8
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batunpc batunpc

Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit tests for messages batunpc/pr-approve-generator
2 participants
@pavelkeyzik @batunpc