fix: Prevent crash in case of empty dataclasses #56
Conversation
src/pytkdocs/loader.py
Outdated
| if "__annotations__" in all_members: | ||
| for field_name, annotation in all_members["__annotations__"].items(): |
There was a problem hiding this comment.
Actually, why don't we iterate on __dataclass_fields__ since we already asserted its existence? Besides, the dataclass field also contains a default value, which we could use for #50
There was a problem hiding this comment.
That's a better idea! Updated.
As far as I can tell, actually using the default value would be a bit more work since it would have to be added to the Attribute object and then presumably used in some serialisation somewhere but I can't immediately see where. So I guess that can happen separately :)
There was a problem hiding this comment.
You are absolutely right 🙂 I will merge this PR as it is, thanks!
|
Thanks again for your contributions, this is really appreciated 🙂
Haha yeah, I agree we should prevent a crash anyway! I left just one comment! |
Ran into this when applying mkdocstrings to a real life project. I won't pretend that there was a legitimate reason to use an empty dataclass in my code, but thought it was worth preventing the crash 🙈