Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users should be able to upload their composer.lock #52

Open
pborreli opened this issue Jan 5, 2014 · 4 comments
Open

users should be able to upload their composer.lock #52

pborreli opened this issue Jan 5, 2014 · 4 comments

Comments

@pborreli
Copy link
Owner

pborreli commented Jan 5, 2014

in that case, we could jump directly to the ServeVendorStep step if this composer.lock had been previously served or use a new one named ComposerInstallStep which will be faster than ComposerUpdateStep

@youbs
Copy link
Collaborator

youbs commented Jan 16, 2014

Do we use another form action and another consumer?

@pborreli
Copy link
Owner Author

I would say no and no :) but not same step as we don't need to composer update but composer install instead

@youbs
Copy link
Collaborator

youbs commented Jan 17, 2014

No we don't use another form/consumer, so we use the same ones?

I was about to make another one because the steps differs, luckily I asked you :)
How do you see it then? more precisely, how do we use some other steps regarding what we uploaded?

@youbs
Copy link
Collaborator

youbs commented Jan 17, 2014

In fact, I was about to modify the controller, and call "createAndPublish" on the backend with two different set of parameters, depending on when we had the composer.json or the composer.lock, and create two different consumer to handle that. I would have added the ComposerInstallStep instead of the ComposerUpdateStep one (and removed the steps we don't need).

So, is this a mistake?

There is still the issue of the UX. Will #79 be merged or not, etc. If so, then do we add a tab for the composer.lock?

But you know what, we''ll talk about that when you come back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants