You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can easily adapt the code to use the other sample formats except i64 and u64 and as far as I understand that is because there is no implementation of RawSample for those.
What I do is return an error in those cases. I just started with audio programming so I am not really in a position to identify if this is an issue or not, but I thought I mention it here.
The text was updated successfully, but these errors were encountered:
Returning an error seems like a reasonable solution for now. I don't think any consumer hardware would use those sample formats anyways.
However, cpal is a critical Rust audio crate, so we should probably consider adding those to Symphonia. Symphonia's SampleFormat is not marked at non-exhaustive though, so adding it without a semver bump could potentially cause breaks. So that part may have to wait.
symphonia-play
is usingcpal = "0.13.3"
. The current version iscpal = "0.15.2"
. Updatingcpal
leads to errors here:Symphonia/symphonia-play/src/output.rs
Line 217 in 82817dd
because
cpal
supports more sample formats now:https://docs.rs/cpal/latest/cpal/enum.SampleFormat.html
I can easily adapt the code to use the other sample formats except i64 and u64 and as far as I understand that is because there is no implementation of
RawSample
for those.What I do is return an error in those cases. I just started with audio programming so I am not really in a position to identify if this is an issue or not, but I thought I mention it here.
The text was updated successfully, but these errors were encountered: