You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
here is one thing that you might want to change to improve the functionality.
in background.js, every context menu item matches many different contexts, and contextMenuHandler the following logic:
info.linkUrl || info.srcUrl || info.frameUrl || info.pageUrl
This may result in surprising behavior, for example if an image is embedded in a link. In this case, it is not possible to share the image, because the extension selects the link.
Consider creating splitting the menu in separate definitions, then up to three menu items can be shown at a given page.
browser.tabs.create({contexts: ["page", "frame"], title: "Share page", ....}) // use info.frameUrl || info.pageUrl in onclick.
browser.tabs.create({contexts: ["link"], title: "Share link", ....}) // use info.linkUrl in onclick
browser.tabs.create({contexts: ["video"], title: "Share video", ....}) // use info.srcUrl in onclick
browser.tabs.create({contexts: ["audio"], title: "Share audio", ....}) // use info.srcUrl in onclick
browser.tabs.create({contexts: ["image"], title: "Share image", ....}) // use info.srcUrl in onclick
If you use the above, then up to three menu items will be displayed (video, audio and image are mutually exclusive).
The text was updated successfully, but these errors were encountered:
Mozilla reviewer (Rob W) writes:
The text was updated successfully, but these errors were encountered: