Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdm import -f setuppy #1062

Closed
jnoortheen opened this issue May 2, 2022 · 2 comments · Fixed by #1137
Closed

pdm import -f setuppy #1062

jnoortheen opened this issue May 2, 2022 · 2 comments · Fixed by #1137
Labels
⭐ enhancement Improvements for existing features
Milestone
Release 2.0

Comments

@jnoortheen
Copy link

Is your feature request related to a problem? Please describe.

As of v1.14.1 this is not implemented.

Describe the solution you'd like

There is a library that implements similar functionality already . pdm can vendor this or use similar approach or can make this a plugin .
@jnoortheen jnoortheen added the ⭐ enhancement Improvements for existing features label May 2, 2022
@frostming
Copy link
Collaborator

The AST parsing approach might be not robust enough and have lots of corner cases to deal with. The only reliable way to get project metadata from a setup.py is to run a setup.py egg_info command.

@frostming frostming added this to the Release 2.0 milestone May 7, 2022
@frostming frostming mentioned this issue Jun 14, 2022
Merged
2 tasks
@frostming frostming linked a pull request Jun 16, 2022 that will close this issue
Feature: setup.py import #1137
Merged
2 tasks
@frostming
Copy link
Collaborator

Closed by #1137, please test it on 2.0.0a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging a pull request may close this issue.

Feature: setup.py import pdm-project/pdm
2 participants
@jnoortheen @frostming