Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Replace halo, click, and termcolor with rich #1091

Merged
merged 8 commits into from
May 22, 2022
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

This PR supersedes #1066

daylinmorgan and others added 3 commits May 22, 2022 10:47
* feat: replace click,halo,termcolor with rich

* refactor: replace fg with style in echo args

* test: update test_run for rich table

* refactor: drop termui.<color> for rich inline syntax

* chore: update pdm.lock

* refactor: remove unneeded ui object

* test: use rich for tests

* refactor: drop colorama and log_symbols (and vendoring)

* chore: remove leftover pdm._vendor mentions

* test: increase column-size and change rich to tomli in test_run
@frostming frostming changed the base branch from main to dev May 22, 2022 07:54
@frostming frostming added this to the Release 2.0 milestone May 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #1091 (2d12254) into dev (58c12a4) will increase coverage by 0.03%.
The diff coverage is 83.74%.

@@            Coverage Diff             @@
##              dev    #1091      +/-   ##
==========================================
+ Coverage   83.86%   83.90%   +0.03%     
==========================================
  Files          75       75              
  Lines        6550     6522      -28     
  Branches     1537     1525      -12     
==========================================
- Hits         5493     5472      -21     
+ Misses        727      720       -7     
  Partials      330      330              
Flag Coverage Δ
unittests 83.70% <83.03%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/commands/export.py 100.00% <ø> (ø)
pdm/cli/commands/show.py 85.41% <ø> (-0.30%) ⬇️
pdm/exceptions.py 100.00% <ø> (ø)
pdm/formats/flit.py 75.55% <0.00%> (ø)
pdm/installers/manager.py 85.71% <ø> (ø)
pdm/models/environment.py 66.66% <ø> (ø)
pdm/models/repositories.py 77.72% <ø> (+0.87%) ⬆️
pdm/cli/commands/plugin.py 64.28% <57.14%> (-0.94%) ⬇️
pdm/cli/actions.py 80.00% <60.00%> (-0.06%) ⬇️
pdm/cli/commands/install.py 90.00% <66.66%> (-0.33%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c12a4...2d12254. Read the comment docs.

@frostming frostming merged commit 54ce1bd into dev May 22, 2022
@frostming frostming deleted the feat/rich-ui branch May 22, 2022 11:26
@frostming frostming mentioned this pull request Jun 12, 2022
9 tasks
frostming added a commit that referenced this pull request Jun 28, 2022
* feat(core): Use tomllib on Python 3.11 (#1072)

* docs: 📝 Fix typo in `pip install pdm` description (#1061)

* Use tomllib on Python 3.11

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* news

* use a compatibility module

* missed one import

Co-authored-by: t106362512 <[email protected]>
Co-authored-by: hauntsaninja <>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(core): Replace halo, click, and termcolor with rich (#1091)

* feat(core): Use `unearth` as the backend to find and download packages (#1096)

* perf(resolver): Speed up the resolution with lazy find_matches (#1098)

* Improve the output of installing packages

* Use confirm instead of ask

* feat(core): New command: pdm publish (#1107)

* Use rich handler for logging to stderr

* feat(scripts): added composite tasks support (#1117)

* feat(core): Add option to skip hooks (#1127)

* fix(scripts): allow pdm test command to receive path arguments

* feat(hooks): added a `--skip` option to skipp scripts and hooks (#1127)

fix #948

* feat(hooks): use PDM_SKIP_HOOKS environement variable as fallback for skip list

* feat(core): Support setup.py import (#1137)

* Update completion script

* fix(resolution): fix a bug that versions with local part can't be found and installed
Close #1093

* feat(core): forbid editable depenencies in project table (#1140)

* Make the error message more friendly

* doc: improve the docs about dependencies

* doc: add CLI reference doc

* doc: use asciiart as the program description

* chore: remove remaining artifacts from #1127 (#1152)

* Feature: complete lifecycle signals and documentation (#1147)

* feat(hooks): Added pre-publish hook

* refactor(hooks): dynamic signal/hooks listing avoiding double declaration

* feat(hooks): added (pre|post)_script and (pre|post)_run hooks

* doc(hooks): added lifecycle and hooks documentation

* review fix

* fix(tests): add and use the _echo fixture for cross-plateform and concise test echos

* refactor(hooks): automatically register the script handler for all hooks

* feat: Update pdm-pep517 to 1.0 (#1153)

* fix(scripts): merge the Script and Description field from listing (#1151)

* feat: fetch the candidate hashes concurrently (#1154)

* feat: fetch the candidate hashes concurrently

* add news

* Feat/respect-source-order (#1155)

* doc: restructure the docs about project metadata and build configuration

* parse pep 621 metadata to avoid build (#1156)

* feat: Remove the compatible support for pdm legacy metadata (#1157)

* fix(config): use platform standard directories for all PDM directories (#1161)

Fixes #1150

* fix(#1156): only trust parsing result when all are static

* New build configuration table

* chore: added a tox.ini file for easier local testing against all Python versions (#1160)

* feat(CLI): Yarn-like root scripts fallback (#1159)

* feat(hooks): added a post_use hook (#1163)

Co-authored-by: Shantanu <[email protected]>
Co-authored-by: t106362512 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Axel H <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants