Give a default version if the version is dynamic in setup.cfg #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 83.85% 84.29% +0.44%
==========================================
Files 74 74
Lines 6545 6547 +2
Branches 1536 1537 +1
==========================================
+ Hits 5488 5519 +31
+ Misses 727 700 -27
+ Partials 330 328 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1 task
dashsatish
reviewed
May 29, 2022
| tui = | ||
| rich | ||
| """, | ||
| Setup("foo", "0.1.0", ["click", "requests"], {"tui": ["rich"]}, ">=3.6"), |
There was a problem hiding this comment.
Will this work if a version is just 2.0. Can you please add this scenario too?
There was a problem hiding this comment.
They are the same case, as long as it is a valid version string.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
news/describing what is new.Describe what you have changed in this PR.