Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip _add_to_path in installer #1145

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

1oglop1
Copy link
Contributor

@1oglop1 1oglop1 commented Jun 19, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

I created a asdf-vm plugin for PDM https://github.com/1oglop1/asdf-pdm.
And created an issue to add it to the community plugins #asdf-community/.github/issues/33.
Also a minor change to a variable name bin which was shadowing builtin function bin.

@1oglop1
Copy link
Contributor Author

1oglop1 commented Jun 19, 2022

I'm not sure how to use news/

@frostming
Copy link
Collaborator

I'm not sure how to use news/

add a news fragment file named {issue_id}.{type}.md under news/, describing what is changed. In this case file should be named 1145.misc.md, where misc is short for "Miscellany"

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #1145 (b062fe5) into main (eab45ca) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   84.30%   84.33%   +0.03%     
==========================================
  Files          74       74              
  Lines        6582     6582              
  Branches     1546     1546              
==========================================
+ Hits         5549     5551       +2     
+ Misses        702      701       -1     
+ Partials      331      330       -1     
Flag Coverage Δ
unittests 84.09% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/models/repositories.py 77.44% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef1c0d...b062fe5. Read the comment docs.

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frostming frostming merged commit c9409d8 into pdm-project:main Jun 20, 2022
@biaocy
Copy link

biaocy commented Jun 23, 2022

For security reasons, you should verify the checksum of install-pdm.py. The sha256 checksum is: 67dccb18923340e21f3d70f9c6a467d532c6a41b295d6f1ba884b27604074d38

Please update the checksum of install-pdm.py file as well, or else people who cares about security, like the one who add it in the first place, would feel a little uncertainty if they find out the latest file checksum is not the same as in README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants