Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A change in resolvelib broke pdm #118

Closed
jmfederico opened this issue May 2, 2020 · 1 comment · Fixed by #119
Closed

A change in resolvelib broke pdm #118

jmfederico opened this issue May 2, 2020 · 1 comment · Fixed by #119
Labels
🐛 bug Something isn't working ⬆️ upstream bug Caused by a bug from the upstream dependencies

Comments

@jmfederico
Copy link

The following change in resolvelib breaks the monkeypatching done by pdm:

sarugaku/resolvelib@eeceaf6#diff-9d16b368db940f0b65c2b9b5ba4d6ed3R71

When resolving dependencies the following error is thrown:
[TypeError]: adding_requirement() missing 1 required positional argument: 'parent'

Problem in pdm:

https://github.com/frostming/pdm/blob/927e4957360a28564a8246088c865135ccb3a784/pdm/resolver/core.py#L19

How to reproduce:

Make a clean install of pdm with newest dependencies updated: resolvelib version 0.4.0
Try to add any dependency to a project with pdm: pdm add ...

@jmfederico jmfederico added the 🐛 bug Something isn't working label May 2, 2020
@frostming
Copy link
Collaborator

Already working on it, thanks for the report

@frostming frostming added the ⬆️ upstream bug Caused by a bug from the upstream dependencies label May 3, 2020
@frostming frostming mentioned this issue May 3, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⬆️ upstream bug Caused by a bug from the upstream dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants