Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix run env overriding pep582 #1211

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Jul 8, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #1211 (20e5bc4) into main (e364230) will increase coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   80.88%   80.93%   +0.04%     
==========================================
  Files          93       93              
  Lines        7622     7621       -1     
  Branches     1796     1772      -24     
==========================================
+ Hits         6165     6168       +3     
+ Misses       1098     1096       -2     
+ Partials      359      357       -2     
Flag Coverage Δ
unittests 80.84% <88.88%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/commands/run.py 91.13% <88.88%> (+0.93%) ⬆️
pdm/models/repositories.py 78.63% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e364230...20e5bc4. Read the comment docs.

@frostming frostming merged commit 337b9b6 into main Jul 8, 2022
@frostming frostming deleted the fix/env-file-overriden branch July 8, 2022 14:06
@mgzenitech
Copy link

Is this going to be released with 1.x release or 2.x ? Any ideas when? :)

@frostming
Copy link
Collaborator Author

@mgzenitech on 2.0, it would be released around this Friday, if no big breakage happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants