Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to ship pip when creating a venv #1463

Merged
merged 4 commits into from
Oct 26, 2022
Merged

feat: option to ship pip when creating a venv #1463

merged 4 commits into from
Oct 26, 2022

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@frostming frostming changed the title Feat/with-pip feat: option to ship pip when creating a venv Oct 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 84.90% // Head: 84.95% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ea882e4) compared to base (39d6c04).
Patch coverage: 94.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
+ Coverage   84.90%   84.95%   +0.05%     
==========================================
  Files          88       88              
  Lines        7643     7658      +15     
  Branches     1792     1796       +4     
==========================================
+ Hits         6489     6506      +17     
  Misses        768      768              
+ Partials      386      384       -2     
Flag Coverage Δ
unittests 84.77% <94.44%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/project/config.py 89.72% <ø> (ø)
src/pdm/cli/commands/venv/backends.py 91.08% <94.11%> (+0.28%) ⬆️
src/pdm/cli/commands/venv/create.py 100.00% <100.00%> (ø)
src/pdm/termui.py 90.57% <0.00%> (+0.72%) ⬆️
src/pdm/models/repositories.py 78.86% <0.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 8ef9276 into main Oct 26, 2022
@frostming frostming deleted the feat/with-pip branch October 26, 2022 03:25
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants