Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"AttributeError: 'BinOp' object has no attribute 's'" when trying to install Transformers as local editable dependency #1720

Closed
1 task done
nickchomey opened this issue Feb 17, 2023 · 0 comments · Fixed by j178/pdm#1
Labels
🐛 bug Something isn't working

Comments

@nickchomey
Copy link

nickchomey commented Feb 17, 2023

  • I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

  1. create new pdm project pdm init
  2. git clone https://github.com/huggingface/transformers.git
  3. pdm add -e ./transformers --dev

Actual behavior

This error message:

Traceback (most recent call last):
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/requirements.py", line 35, in __init__
    parsed = parse_requirement(requirement_string)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_parser.py", line 64, in parse_requirement
    return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_parser.py", line 73, in _parse_requirement
    name_token = tokenizer.expect(
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_tokenizer.py", line 138, in expect
    raise self.raise_syntax_error(f"Expected {expected}")
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_tokenizer.py", line 163, in raise_syntax_error
    raise ParserSyntaxError(
packaging._tokenizer.ParserSyntaxError: Expected package name at the start of dependency specifier
    ./transformers
    ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 482, in parse_as_pkg_requirement
    return PackageRequirement(line)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/requirements.py", line 37, in __init__
    raise InvalidRequirement(str(e)) from e
packaging.requirements.InvalidRequirement: Expected package name at the start of dependency specifier
    ./transformers
    ^

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/requirements.py", line 35, in __init__
    parsed = parse_requirement(requirement_string)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_parser.py", line 64, in parse_requirement
    return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_parser.py", line 73, in _parse_requirement
    name_token = tokenizer.expect(
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_tokenizer.py", line 138, in expect
    raise self.raise_syntax_error(f"Expected {expected}")
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/_tokenizer.py", line 163, in raise_syntax_error
    raise ParserSyntaxError(
packaging._tokenizer.ParserSyntaxError: Expected package name at the start of dependency specifier
    ./transformers
    ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 508, in parse_requirement
    pkg_req = parse_as_pkg_requirement(line)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 489, in parse_as_pkg_requirement
    return PackageRequirement(new_line)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/packaging/requirements.py", line 37, in __init__
    raise InvalidRequirement(str(e)) from e
packaging.requirements.InvalidRequirement: Expected package name at the start of dependency specifier
    ./transformers
    ^

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nick/.local/bin/pdm", line 8, in <module>
    sys.exit(main())
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/core.py", line 259, in main
    return Core().main(args)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/core.py", line 191, in main
    raise cast(Exception, err).with_traceback(traceback)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/core.py", line 186, in main
    f(project, options)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/cli/commands/add.py", line 58, in handle
    actions.do_add(
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/cli/actions.py", line 257, in do_add
    for r in [parse_requirement(line, True) for line in editables] + [
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/cli/actions.py", line 257, in <listcomp>
    for r in [parse_requirement(line, True) for line in editables] + [
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 513, in parse_requirement
    r = FileRequirement.create(**m.groupdict())
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 275, in create
    return super().create(**kwargs)  # type: ignore
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 158, in create
    return cls(
  File "<string>", line 12, in __init__
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 266, in __post_init__
    self._check_installable()
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/requirements.py", line 385, in _check_installable
    result = Setup.from_directory(self.path.absolute())
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/setup.py", line 37, in from_directory
    return _SetupReader.read_from_directory(dir)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/setup.py", line 61, in read_from_directory
    new_result = file_reader(filepath)
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/setup.py", line 100, in read_setup_py
    install_requires=cls._find_install_requires(setup_call, body),
  File "/home/nick/.local/share/pdm/venv/lib/python3.10/site-packages/pdm/models/setup.py", line 264, in _find_install_requires
    install_requires.append(el.s)
AttributeError: 'BinOp' object has no attribute 's'

Expected behavior

I'd expect it to be installed. Interestingly, if you install with pdm add -e git+https://github.com/huggingface/transformers.git --dev, it installs just fine.

Here's a seemingly relevant issue from Poetry: python-poetry/poetry#1900

Environment Information

# Paste the output of `pdm info && pdm info --env` below:
PDM version:
  2.4.5
Python Interpreter:
  /home/nick/zxcv/.venv/bin/python (3.10)
Project Root:
  /home/nick/zxcv
Project Packages:
  None
{
  "implementation_name": "cpython",
  "implementation_version": "3.10.6",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "5.15.90.1-microsoft-standard-WSL2",
  "platform_system": "Linux",
  "platform_version": "#1 SMP Fri Jan 27 02:56:13 UTC 2023",
  "python_full_version": "3.10.6",
  "platform_python_implementation": "CPython",
  "python_version": "3.10",
  "sys_platform": "linux"
}
@nickchomey nickchomey added the 🐛 bug Something isn't working label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant