Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install build requirements into wrong location when running with --venv #2314

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/pdm/builders/base.py 89.20% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@frostming frostming merged commit 0173bde into main Oct 13, 2023
@frostming frostming deleted the fix/build-requires branch October 13, 2023 08:29
@frostming frostming restored the fix/build-requires branch October 13, 2023 08:29
@frostming frostming deleted the fix/build-requires branch October 13, 2023 08:30
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant