Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install headers into package namespace #2574

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8822de5) 84.74% compared to head (0cc0a54) 84.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
+ Coverage   84.74%   84.76%   +0.02%     
==========================================
  Files         104      104              
  Lines       10373    10387      +14     
  Branches     2270     2272       +2     
==========================================
+ Hits         8791     8805      +14     
  Misses       1106     1106              
  Partials      476      476              
Flag Coverage Δ
unittests 84.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit abde992 into main Jan 19, 2024
21 checks passed
@frostming frostming deleted the fix/include-namespace branch January 19, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant