Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create venv when switching python versions #2720

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>
add news

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>
fix tests

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Signed-off-by: Frost Ming <[email protected]>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (ba72e45) to head (235541a).

Files Patch % Lines
src/pdm/project/core.py 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2720   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files         105      105           
  Lines       10417    10414    -3     
  Branches     2272     2271    -1     
=======================================
- Hits         8843     8841    -2     
  Misses       1101     1101           
+ Partials      473      472    -1     
Flag Coverage Δ
unittests 84.68% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit d50654d into main Mar 26, 2024
20 of 21 checks passed
@frostming frostming deleted the feat/ensure-venv branch March 26, 2024 08:40
@pawamoy
Copy link
Contributor

pawamoy commented Mar 26, 2024

Nice, this will be super helpful 🙂

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants