Extract the logic of finding interpreters to a method #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
reviewed
Mar 22, 2021
| @@ -515,3 +516,25 @@ def make_candidate_info_cache(self) -> CandidateInfoCache: | |||
|
|
|||
| def make_hash_cache(self) -> HashCache: | |||
| return HashCache(directory=self.cache("hashes").as_posix()) | |||
|
|
|||
| def find_interpreters(self, python_spec: str) -> Iterable[str]: | |||
There was a problem hiding this comment.
why return a str here instead of a Path?
danieleades
reviewed
Mar 22, 2021
danieleades
reviewed
Mar 22, 2021
danieleades
reviewed
Mar 22, 2021
danieleades
reviewed
Mar 22, 2021
| @@ -417,7 +417,7 @@ def do_use(project: Project, python: str, first: bool = False) -> None: | |||
| The python can be a version string or interpreter path. | |||
| """ | |||
| python = python.strip() | |||
| found_interpreters = list(project.find_interpreters(python)) | |||
| found_interpreters = list(dict.fromkeys(project.find_interpreters(python))) | |||
There was a problem hiding this comment.
found_interpreters = set(project.find_interpreters(python))?
There was a problem hiding this comment.
Nope, the difference is dict.fromkeys() preserves the order while set doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
news/describing what is new.Describe what you have changed in this PR.
As title