Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write installer metadata #3359

Merged
merged 2 commits into from
Dec 26, 2024
Merged

fix: write installer metadata #3359

merged 2 commits into from
Dec 26, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (19f84aa) to head (3431545).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
+ Coverage   85.21%   85.23%   +0.01%     
==========================================
  Files         112      112              
  Lines       11461    11469       +8     
  Branches     2505     2509       +4     
==========================================
+ Hits         9767     9776       +9     
  Misses       1168     1168              
+ Partials      526      525       -1     
Flag Coverage Δ
unittests 85.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit e4eb940 into main Dec 26, 2024
21 checks passed
@frostming frostming deleted the fix/installer-metadata branch December 26, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant