Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pdm.cli.actions #428

Merged
merged 5 commits into from
May 6, 2021

Conversation

danieleades
Copy link
Contributor

address a handful of type errors in pdm.cli.actions

this is stacked on #427

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #428 (a14765c) into master (229e455) will decrease coverage by 0.05%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   83.48%   83.43%   -0.06%     
==========================================
  Files          68       68              
  Lines        5309     5311       +2     
  Branches      944      945       +1     
==========================================
- Hits         4432     4431       -1     
- Misses        602      609       +7     
+ Partials      275      271       -4     
Flag Coverage Δ
unittests 83.35% <95.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/actions.py 73.86% <91.66%> (-0.19%) ⬇️
pdm/cli/utils.py 81.88% <100.00%> (+0.66%) ⬆️
pdm/models/setup.py 54.15% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229e455...a14765c. Read the comment docs.

@frostming
Copy link
Collaborator

LGTM, is the type error of pdm.cli.actions clear?

@danieleades
Copy link
Contributor Author

LGTM, is the type error of pdm.cli.actions clear?

no, this pull request doesn't fully eliminate type errors from this file, just reduces the number

@frostming frostming merged commit 62edf5f into pdm-project:master May 6, 2021
@danieleades danieleades deleted the refactor/pdm.cli.actions branch May 6, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants