Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be used with devcontainers? #542

Closed
mr-rodgers opened this issue Jul 18, 2021 · 1 comment
Closed

Can this be used with devcontainers? #542

mr-rodgers opened this issue Jul 18, 2021 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@mr-rodgers
Copy link

mr-rodgers commented Jul 18, 2021

I can't seem to find a valid way to use this tool within a devcontainer (VS Code).

The main issue seems to be that the tool locks down the pyproject.toml and pdm.lock files to the executing user with rw-/---/--- permissions. If you mount the project directory inside a docker container and then run pdm add * from inside the container, this means that the files will be locked so that they can only be read by root on the host. This then causes any subsequent rebuild of the container to fail, as these files are copied empty by the docker daemon, which in turn causes the tool to fail in installation.

I contrast this to poetry, which respects the umask (doesn't force the permissions to rw-/---/---) on pyproject and doesn't suffer from this same issue.

@frostming
Copy link
Collaborator

Thanks for catching this, a fix is on the way

@frostming frostming added the 🐛 bug Something isn't working label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants