Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: switch to importlib.metadata.Distribution #592

Merged
merged 6 commits into from
Aug 10, 2021

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #592 (5e452f2) into main (39189bb) will increase coverage by 0.00%.
The diff coverage is 84.12%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files          71       72    +1     
  Lines        5915     5935   +20     
  Branches     1044     1055   +11     
=======================================
+ Hits         4995     5012   +17     
+ Misses        640      635    -5     
- Partials      280      288    +8     
Flag Coverage Δ
unittests 84.26% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/commands/plugin.py 65.21% <50.00%> (ø)
pdm/installers/manager.py 85.71% <66.66%> (ø)
pdm/installers/uninstallers.py 83.41% <73.91%> (+0.08%) ⬆️
pdm/builders/base.py 91.78% <83.33%> (+0.05%) ⬆️
pdm/cli/utils.py 82.69% <84.21%> (-0.46%) ⬇️
pdm/models/working_set.py 84.44% <84.44%> (ø)
pdm/_types.py 100.00% <100.00%> (ø)
pdm/cli/actions.py 75.64% <100.00%> (-0.16%) ⬇️
pdm/installers/synchronizers.py 84.50% <100.00%> (+0.14%) ⬆️
pdm/models/environment.py 71.05% <100.00%> (-4.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39189bb...5e452f2. Read the comment docs.

@frostming frostming force-pushed the refactor/importlib-distribution branch from 0008a7c to c051a00 Compare August 10, 2021 01:40
@frostming frostming merged commit 1f83b7e into main Aug 10, 2021
@frostming frostming deleted the refactor/importlib-distribution branch August 10, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants