Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-isolation option to build command #635

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #635 (36eeb4a) into main (fd45c85) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   83.64%   83.66%   +0.02%     
==========================================
  Files          72       72              
  Lines        6046     6056      +10     
  Branches     1073     1075       +2     
==========================================
+ Hits         5057     5067      +10     
  Misses        699      699              
  Partials      290      290              
Flag Coverage Δ
unittests 83.45% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/builders/base.py 91.71% <100.00%> (+0.50%) ⬆️
pdm/cli/actions.py 76.00% <100.00%> (ø)
pdm/cli/commands/build.py 84.61% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd45c85...36eeb4a. Read the comment docs.

@frostming frostming merged commit 0a5d5ed into main Sep 2, 2021
@frostming frostming deleted the feature/no-isolation branch September 2, 2021 00:58
@frostming frostming mentioned this pull request Sep 3, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants