Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDM Clobbering SSH Username #68

Closed
kevinastone opened this issue Mar 8, 2020 · 1 comment · Fixed by #69
Closed

PDM Clobbering SSH Username #68

kevinastone opened this issue Mar 8, 2020 · 1 comment · Fixed by #69
Labels
🐛 bug Something isn't working

Comments

@kevinastone
Copy link

A requirement of the form git@server:repo.git gets translated into ssh://server/repo.git, dropping the git@ username component of the url. This then fails cloning if the server requires that git username (as GitHub does).

The issue is this line (specifically self.url[4:]) that slices out the username when constructing the ssh:// url. You can bypass this errant special casing with an explicit ssh:// schema (e.g. ssh://git@server/repo.git).
@kevinastone kevinastone added the 🐛 bug Something isn't working label Mar 8, 2020
@frostming
Copy link
Collaborator

Yeah, a bug fix is on the way

@frostming frostming mentioned this issue Mar 9, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SSH URL parsing pdm-project/pdm
2 participants
@kevinastone @frostming