Strip trailing whitespace with pdm-show #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
fix-show-rstrip
branch
from
ab65cad to
9360d73
Compare
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
==========================================
- Coverage 83.70% 83.66% -0.05%
==========================================
Files 73 73
Lines 6111 6114 +3
Branches 1082 1083 +1
==========================================
Hits 5115 5115
- Misses 704 707 +3
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
A news fragment is required, thanks |
pdm-show uses `project.core.ui.display_columns`, which adds trailing spaces to all the lines (based on the longest one), which results in them being displayed/wrapped when the terminal is not wide enough for the longest line: ``` % pdm show coverage|cat -A Name: coverage …$ Latest version: 6.0.2 …$ … Project URLs: Documentation: https://coverage.readthedocs.io …$ Funding: https://example.com/?utm_source=foobar…$ … ``` This patch just adds `rstrip()`, which gets rid of it, while still keeping the maybe too long underline for the header (not used with pdm-show). Maybe this could use $COLUMNS / the terminal width to limit the length of the header underline, but that is not really needed / not trivial.
blueyed
force-pushed
the
fix-show-rstrip
branch
from
9360d73 to
fe3a0c2
Compare
Added/amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
news/describing what is new.Describe what you have changed in this PR.
pdm-show uses
project.core.ui.display, which adds trailing spaces to all thelines (based on the longest one), which results in them being displayed/wrapped
when the terminal is not wide enough for the longest line:
This patch just adds
rstrip(), which gets rid of it, while stillkeeping the maybe too long underline for the header (not used with
pdm-show).
Maybe this could use $COLUMNS / the terminal width to limit the length
of the header underline, but that is not really needed / not trivial.