-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add support for Conda environments #749
Conversation
Codecov Report
@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 83.53% 83.39% -0.15%
==========================================
Files 73 73
Lines 6154 6167 +13
Branches 1101 1103 +2
==========================================
+ Hits 5141 5143 +2
- Misses 720 731 +11
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I don't have time to work on this right now, but I'm thinking about the following changes:
This would change the behaviour — right now, as you point out, we don't check if |
That is a good change, while I prefer to bind it to |
661a4b4
to
0f558e4
Compare
I think we might want to refactor the virtual-environment support here, but I think we should do so in a different PR. I experimented with adding this information to the For my future benefit:
Another name for these classes might be |
8ad741a
to
98dfe3a
Compare
Pull Request Check List
news/
describing what is new.Describe what you have changed in this PR.
This PR adds support for
CONDA_PREFIX
where virtual environments are implemented using Conda.