Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip import in install-pdm.py #780

Closed
u1138 opened this issue Dec 8, 2021 · 2 comments
Closed

pip import in install-pdm.py #780

u1138 opened this issue Dec 8, 2021 · 2 comments

Comments

@u1138
Copy link

u1138 commented Dec 8, 2021

install-pdm.py requires pre-installed pip:

from pip import __file__ as pip_location

It appears that pre-installed pip is used only to install virtualenv package, however this step is not needed in many or most cases. Maybe it would be better to move the import from the top of the script inside the function, or even to use alternative virtualenv install method via zipapp just like in install-poetry.py?

@frostming
Copy link
Collaborator

Thanks, will do

@frostming
Copy link
Collaborator

Fixed in 8b3ebd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants