Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to tomlkit #809

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Switch back to tomlkit #809

merged 2 commits into from
Dec 20, 2021

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Dec 20, 2021

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #807

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #809 (37c39d7) into main (b6e1f70) will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          74       74           
  Lines        6258     6258           
  Branches     1123     1123           
=======================================
  Hits         5227     5227           
  Misses        736      736           
  Partials      295      295           
Flag Coverage Δ
unittests 83.31% <92.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/actions.py 77.15% <60.00%> (ø)
pdm/cli/commands/run.py 85.48% <100.00%> (ø)
pdm/cli/utils.py 80.06% <100.00%> (ø)
pdm/formats/base.py 100.00% <100.00%> (ø)
pdm/project/config.py 96.11% <100.00%> (ø)
pdm/project/core.py 89.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97252e...37c39d7. Read the comment docs.

@frostming frostming merged commit cb186d8 into main Dec 20, 2021
@frostming frostming deleted the dep/tomlkit branch December 20, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during pdm import
2 participants