Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pythonfinder to findpython #930

Merged
merged 9 commits into from
Feb 21, 2022
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #930 (4e29fed) into main (3ce5029) will decrease coverage by 0.56%.
The diff coverage is 93.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   84.03%   83.47%   -0.57%     
==========================================
  Files          74       74              
  Lines        6478     6461      -17     
  Branches     1342     1341       -1     
==========================================
- Hits         5444     5393      -51     
- Misses        709      750      +41     
+ Partials      325      318       -7     
Flag Coverage Δ
unittests 83.23% <93.02%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/models/in_process/__init__.py 88.46% <ø> (+1.28%) ⬆️
pdm/models/repositories.py 76.75% <ø> (-0.88%) ⬇️
pdm/project/core.py 89.91% <75.00%> (ø)
pdm/models/environment.py 64.28% <80.00%> (-1.59%) ⬇️
pdm/builders/base.py 91.12% <100.00%> (ø)
pdm/cli/actions.py 79.88% <100.00%> (-0.06%) ⬇️
pdm/cli/commands/info.py 92.85% <100.00%> (ø)
pdm/installers/installers.py 82.73% <100.00%> (-1.20%) ⬇️
pdm/models/python.py 92.45% <100.00%> (-3.98%) ⬇️
pdm/models/setup.py 42.68% <0.00%> (-10.28%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce5029...4e29fed. Read the comment docs.

@frostming frostming merged commit 4b1507d into main Feb 21, 2022
@frostming frostming deleted the dep/switch-to-findpython branch February 21, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants