This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Add extractTypeDescribedValue to PropsTable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be cool to add it as JSX tags, so we could style the different types? |
|
Yeah, I'm thinking improve this PropsTable later. But for now I only want to fix the bugs. |
|
Thanks @renatorib 🙏 |
pedronauck
pushed a commit
that referenced
this pull request
Jun 15, 2018
* fix(docz): add extractTypeDescribedValue to PropsTable * fix(docz): show PropsTable shape in brackets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Description
Treat different kind of prop types.
It ignore complex types, like recursive types and others.
Good reference: https://github.com/reactjs/react-docgen/blob/55bbefed8321d535e53786b684708bd618cc15fb/src/utils/__tests__/getPropType-test.js
Pre-merge checklist