From 1fd8f5b1edefc3fe796440b6e8aa18fa2de987df Mon Sep 17 00:00:00 2001 From: sinryuji Date: Thu, 8 Feb 2024 16:33:31 +0900 Subject: [PATCH] refactor: request logging --- .../backend/aspect/RequestLoggingAspect.java | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/main/java/peer/backend/aspect/RequestLoggingAspect.java b/src/main/java/peer/backend/aspect/RequestLoggingAspect.java index 35a0a1752..c09e3085a 100644 --- a/src/main/java/peer/backend/aspect/RequestLoggingAspect.java +++ b/src/main/java/peer/backend/aspect/RequestLoggingAspect.java @@ -42,6 +42,8 @@ private String getRequestInfo(ProceedingJoinPoint pjp, HttpServletRequest reques .append(" ") .append(request.getRequestURI()) .append(" ") + .append(request.getRemoteAddr()) + .append(" ") .append(params) .toString(); } @@ -61,24 +63,19 @@ public Object loggingApi(ProceedingJoinPoint pjp) throws Throwable { ObjectMapper mapper = new ObjectMapper(); mapper.registerModule(new JavaTimeModule()); String requestInfo = this.getRequestInfo(pjp, request); - + long start = System.currentTimeMillis(); try { - long start = System.currentTimeMillis(); - log.info("[Request] {}", requestInfo); - Object result = pjp.proceed(); - long end = System.currentTimeMillis(); - log.info("[Response] {}: {} < ({}ms)", requestInfo, - mapper.writeValueAsString(result), end - start); - return result; + return pjp.proceed(); } catch (Exception e) { StringBuilder message = new StringBuilder(); - for (StackTraceElement stackTraceElement : e.getStackTrace()) { message.append(System.lineSeparator()).append(stackTraceElement.toString()); } - - log.error("[Error] {} {} {}", requestInfo, e, message.toString()); + log.error("[Error] {} {} {}", requestInfo, e, message); throw e; + } finally { + long end = System.currentTimeMillis(); + log.info("[Request] {} < ({}ms)", requestInfo, end - start); } } -} +} \ No newline at end of file