Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename failedFields to errors #8

Closed
jhnns opened this issue Feb 24, 2014 · 1 comment
Closed

Rename failedFields to errors #8

jhnns opened this issue Feb 24, 2014 · 1 comment
Assignees
@jhnns

Comments

@jhnns
Copy link
Member

jhnns commented Feb 24, 2014

I know this seems like "stupid" discussion, but I think naming is important and short and descriptive names are always a sign of a good api.

Imho in the validation context using errors is sufficient. But this is somehow related to our discussion regarding whole model errors. If there are these kinds of errors errors would not be descriptive enough.

So we should discuss whole model errors first and then decide here.
@jhnns jhnns self-assigned this Feb 24, 2014
@meaku
Copy link
Member

meaku commented Feb 24, 2014

I don't like failedFields ether :)

@jhnns jhnns closed this as completed in 93c50ed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhnns jhnns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhnns @meaku