Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): updating dockerfile to copy and install packages in the w… #485

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

pushkar-geospoc
Copy link
Contributor

…orkdir

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀


Here's what actually got changed 👏


Here's how others can test the changes 👀

@missinglink
Copy link
Member

missinglink commented Jun 22, 2022

Good catch, what was it doing before?
I guess it was still working due to copying into the CWD which was equivalent?

@pushkar-geospoc
Copy link
Contributor Author

Good catch, what was it doing before? I guess it was still working due to copying into the CWD which was equivalent?

yes due to CWD it was working but the dockerfile was inconsistent so think is better to make it consistent

@missinglink missinglink merged commit 777b824 into pelias:master Jun 22, 2022
@missinglink
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants