You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this module, as a TOML parser, shouldn't depend on another TOML and YML parser for benchmarking.
It would probably be best if another repository could be made for benchmarks that rely on other libraries such as BurntSushi's. Otherwise, I think it's better to remove the benchmarks.
module github.com/pelletier/go-toml
go 1.12
require (
github.com/BurntSushi/toml v0.3.1 // for benchmarking
github.com/davecgh/go-spew v1.1.1
gopkg.in/yaml.v2 v2.3.0 // also for benchmarking
)
The text was updated successfully, but these errors were encountered:
diamondburned
changed the title
Remove burntsushi/toml dependency
Remove/Separate benchmarking dependencies
Jun 12, 2020
I agree, would be better with no dependency. I'd still like to keep the benchmarks around in this repository. Wonder if we can put them in a sub-folder with their dedicated go.mod file.
I think this module, as a TOML parser, shouldn't depend on another TOML and YML parser for benchmarking.
It would probably be best if another repository could be made for benchmarks that rely on other libraries such as BurntSushi's. Otherwise, I think it's better to remove the benchmarks.
For reference, here's the
go.mod
as of this issue:The text was updated successfully, but these errors were encountered: