Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Separate benchmarking dependencies #418

Closed
diamondburned opened this issue Jun 12, 2020 · 2 comments
Closed

Remove/Separate benchmarking dependencies #418

diamondburned opened this issue Jun 12, 2020 · 2 comments
Assignees

Comments

@diamondburned
Copy link

I think this module, as a TOML parser, shouldn't depend on another TOML and YML parser for benchmarking.

It would probably be best if another repository could be made for benchmarks that rely on other libraries such as BurntSushi's. Otherwise, I think it's better to remove the benchmarks.

For reference, here's the go.mod as of this issue:

module github.com/pelletier/go-toml

go 1.12

require (
	github.com/BurntSushi/toml v0.3.1 // for benchmarking
	github.com/davecgh/go-spew v1.1.1
	gopkg.in/yaml.v2 v2.3.0 // also for benchmarking
)
@diamondburned diamondburned changed the title Remove burntsushi/toml dependency Remove/Separate benchmarking dependencies Jun 12, 2020
@pelletier
Copy link
Owner

I agree, would be better with no dependency. I'd still like to keep the benchmarks around in this repository. Wonder if we can put them in a sub-folder with their dedicated go.mod file.

@AllenX2018 AllenX2018 self-assigned this Jun 14, 2020
@AllenX2018
Copy link
Contributor

Good idea. I will try to move them to a sub-folder like "benchmark" with a dedicated go.mod file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants