Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app sign-in flow for ARS #362

Closed
prayagd opened this issue Jan 9, 2025 · 4 comments
Closed

Improve app sign-in flow for ARS #362

prayagd opened this issue Jan 9, 2025 · 4 comments

Comments

@prayagd
Copy link
Collaborator

prayagd commented Jan 9, 2025

User story

As a ARS offramp user, when i do wallet connect from desktop app, then confirm i want to see a screen telling me that txn in progress and to continue in your Wallet

Acceptance criteria

  • When user clicks on the confirm button, show a notification window on the bottom right corner.
  • Clicking confirm triggers the signing request in the wallet. User does not have to click again to sign
  • Message for the notification window - Align to the current wording

Reference

Screenshot 2025-01-09 at 6 27 58 PM
@prayagd prayagd changed the title Improve verification signature flow for ARS Improve app sign-in flow for ARS Jan 9, 2025
@prayagd
Copy link
Collaborator Author

prayagd commented Jan 13, 2025

@gianfra-t #351 i see this the the replica of 351, please follow the acceptance criteria from here while implementing. as 351 is already been estimated so wont ask estimates here and just keep this here until 351 is closed. Also let me know if any doubts with the acceptance criteria
cc @pendulum-chain/devs

@ebma
Copy link
Member

ebma commented Jan 13, 2025

@prayagd if I understand correctly, we can ignore the screenshot you put as a reference? Seems to me like the change is about 1) immediately requesting the signature without an extra dialog and 2) show the signing-box that we also show elsewhere for 'sign-in'-transaction. Or do you want us to change the text of the signing-box to 'app.vortexfinance.co wants you to sign in with your account:...'? I think this would be redundant.

@prayagd
Copy link
Collaborator Author

prayagd commented Jan 16, 2025

we can ignore the screenshot you put as a reference?

Yes

  1. immediately requesting the signature without an extra dialog

Yes

show the signing-box that we also show elsewhere for 'sign-in'-transaction. Or do you want us to change the text of the signing-box to 'app.vortexfinance.co wants you to sign in with your account:...'?

No

@prayagd
Copy link
Collaborator Author

prayagd commented Jan 28, 2025

Closing as this is done

@prayagd prayagd closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ebma @prayagd and others