Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ed25519-dalek stub code #1693

Closed
1 of 3 tasks
Tracked by #1698
erwanor opened this issue Dec 4, 2022 · 4 comments · Fixed by #2009
Closed
1 of 3 tasks
Tracked by #1698

Remove ed25519-dalek stub code #1693

erwanor opened this issue Dec 4, 2022 · 4 comments · Fixed by #2009
Assignees
@erwanor
Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase

Comments

@erwanor
Copy link
Member

erwanor commented Dec 4, 2022 •
edited by hdevalence
Loading

We want to remove the ed25519-dalek stub code (in pcli and pd) once tendermint-rs transitions to ed25519-consensus. The latter has been tracked and resolved in informalsystems/tendermint-rs#355, but was ultimately part of a yanked release.

Desired changes:
@erwanor erwanor added A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase labels Dec 4, 2022
@erwanor erwanor self-assigned this Dec 4, 2022
@erwanor erwanor mentioned this issue Dec 4, 2022
Closed
6 tasks
@hdevalence
Copy link
Member

Point #1 is addressed by informalsystems/tendermint-rs#1245

@hdevalence
Copy link
Member

The first point is done now that informalsystems/tendermint-rs#1245 has been merged; we just have to wait for it to propagate through our dep tree.

@erwanor erwanor moved this to Future in Testnets Feb 3, 2023
@erwanor erwanor mentioned this issue Feb 3, 2023
Closed
@erwanor erwanor moved this from Future to Testnet 44: Ananke in Testnets Feb 3, 2023
@conorsch
Copy link
Contributor

As with #1932, we're waiting on upstream to release.

@conorsch conorsch moved this from Testnet 44: Ananke to Future in Testnets Feb 10, 2023
@erwanor
Copy link
Member Author

erwanor commented Feb 18, 2023 •
edited
Loading

[email protected] is now out, we're just waiting for [email protected] (informalsystems/ibc-rs#444) and [email protected] (cosmos/ibc-proto-rs#62) to be published and we should be good to go to close this.

@erwanor erwanor mentioned this issue Feb 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from Future to Testnet 45: Meti in Testnets Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase
Projects
No open projects
Testnets
Status: Testnet 45: Meti
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use tendermint-29 and ed25519-consensus penumbra-zone/penumbra
3 participants
@hdevalence @conorsch @erwanor