pg_replication_slots in standby #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WAL functions cannot be executed in standby servers ``` ERROR: recovery is in progress HINT: WAL control functions cannot be executed during recovery. ``` In PostgreSQL 16 replication slots persist in the standby servers. This is also the case when using extensions like pg_failover_slots that transfer the slot information to the standby. This condition will make those queries to return values only in the primary node avoiding the errors.
|
|
|
Hello @fmbiete, thank you for your contribution. We recommend creating the same PR for the upstream project. |
|
But since PMM is including Percona forked postgres_exporter, can we merge the change here? |
BupycHuk
requested changes
Oct 26, 2023
BupycHuk
approved these changes
Oct 26, 2023
JiriCtvrtka
approved these changes
Jan 10, 2024
|
@fmbiete Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAL functions cannot be executed in standby servers
In PostgreSQL 16 replication slots persist in the standby servers. This is also the case when using extensions like pg_failover_slots that transfer the slot information to the standby.
This condition will make those queries to return values only in the primary node avoiding the errors.