Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting PcpMmvWriter does not clear all objects related to metrics #38

Closed
ryandoyle opened this issue Nov 14, 2016 · 2 comments · Fixed by #127
Closed

Resetting PcpMmvWriter does not clear all objects related to metrics #38

ryandoyle opened this issue Nov 14, 2016 · 2 comments · Fixed by #127

Comments

@ryandoyle
Copy link
Contributor

Calling io.pcp.parfait.dxm.BasePcpWriter#reset clears metricData but there are several references held on to PcpMetricInfos, InstanceDomains, PcpStrings and PcpValueInfos (PcpValueInfos are cleared in metricData map but there is a reference held in the perMetricByteBuffers map).

Maps/arrays/stores are as follows:

io.pcp.parfait.dxm.BasePcpWriter#metricInfoStore
io.pcp.parfait.dxm.BasePcpWriter#instanceDomainStore
io.pcp.parfait.dxm.PcpMmvWriter#stringInfo
io.pcp.parfait.dxm.BasePcpWriter#perMetricByteBuffers

These data structures should also be cleared out when #reset is called. I'm more just making a note of this at the moment. I noticed this when working on MMV v2 support but haven't tackled this object leak as part of that issue. The patch set is already fairly large.

@pwinckles
Copy link
Contributor

This was fixed in #121

@pwinckles
Copy link
Contributor

I take that back. Only the byte buffer leak has been fixed. metricInfoStore and instanceDomainStore don't leak. This leaves stringInfo still needing to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants