Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass search data in callbacks (input and results) #153

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

gjaldon
Copy link
Contributor

@gjaldon gjaldon commented Nov 7, 2016

Closes #141

Hi there! Thanks for your work on this. We are using this lib in our app at work. :)

Let me know if there are changes needed.

@perliedman
Copy link
Owner

Hi! Thanks, this looks great. I have a nitpick, though: I'd prefer to change the name callbackData to something else, since the events aren't really callbacks, at least that's not usually how people think about them (even though a listener of course technically is a callback). How about eventData or similar?

@gjaldon gjaldon force-pushed the search-data-in-callbacks branch from e5e1aab to 1f059f2 Compare November 7, 2016 11:38
@gjaldon
Copy link
Contributor Author

gjaldon commented Nov 7, 2016

eventData does sound a lot better than callbackData. I renamed the var to eventData and did a force push.

@perliedman perliedman merged commit 78ad2da into perliedman:master Nov 7, 2016
@perliedman
Copy link
Owner

👍 Thanks, great help and really good to hear that you're putting the code to use at your company!

@gjaldon
Copy link
Contributor Author

gjaldon commented Nov 7, 2016

Thank you for this too, Per! 👍

On Mon, Nov 7, 2016 at 8:01 PM, Per Liedman [email protected]
wrote:

👍 Thanks, great help and really good to hear that you're putting the
code to use at your company!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#153 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABY-QjE05RT2Folgyjfl48wzOwXi79LTks5q7xMvgaJpZM4KrE0h
.

Gabe Jaldon

@gjaldon gjaldon deleted the search-data-in-callbacks branch November 7, 2016 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants