Add code lint (flake8, black, and pytype) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity is supported from 3.7 though.
petrikvladimir
changed the title
kzorina
reviewed
Feb 28, 2023
| @@ -4,19 +4,27 @@ | |||
| # Created on: 2022-12-6 | |||
| # Author: Vladimir Petrik <[email protected]> | |||
| # | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Just curious, how are the annotations used? I did not see in the code
There was a problem hiding this comment.
It allows using str | None for type annotation instead of Optional[str]. It's supported from python 3.10, __future __ import is needed for backporting this future to python 3.7.
kzorina
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two static code checkers into the repository: flake8, black, and pytype. The code is updated to fit the requirements of both.