Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of setuptools? #238

Closed
ariscn opened this issue Apr 20, 2016 · 9 comments
Closed

Old version of setuptools? #238

ariscn opened this issue Apr 20, 2016 · 9 comments
Assignees

Comments

@ariscn
Copy link

ariscn commented Apr 20, 2016

https://github.com/pantsbuild/pex/blob/master/pex/version.py pins setuptools <20. Are there any known issues with more recent versions?

@jsirois
Copy link
Member

jsirois commented Apr 20, 2016

No known, issues, but no research either. If you don't mind consulting the CHANGELOGs, testing and sending a PR noting all this, that would be wonderful.

@jsirois
Copy link
Member

jsirois commented Apr 21, 2016

In preparation for the 1.1.5 release I thought about widening the pin range, but the CHANGELOG is large and will take some careful vetting alnog with the switch to v-prefixed versions: https://pythonhosted.org/setuptools/history.html

@ariscn
Copy link
Author

ariscn commented Apr 22, 2016

I've been using the latest setuptools with pex for a few days without issue so far.

@jsirois jsirois self-assigned this Apr 26, 2016
This was referenced Apr 26, 2016
@jsirois
Copy link
Member

jsirois commented Apr 26, 2016

@ariscn - If you're available to review #244 I'd be grateful.

@jsirois
Copy link
Member

jsirois commented Apr 26, 2016

Fix is in master @ ab2b511

@ariscn
Copy link
Author

ariscn commented Apr 26, 2016

Nice! Will upgrade to master now and report back if anything breaks.

@epu
Copy link

epu commented Jun 3, 2016

@ariscn Did anything break? Could there be a new release, or is more testing needed?

@ariscn
Copy link
Author

ariscn commented Jun 3, 2016

There have been several Pex releases since I opened this issue. :-)

@epu
Copy link

epu commented Jun 3, 2016

Ah, ok. I'm having the same issue with a module requesting latest setuptools (22.0.0). I guess I can roll my own and see how it goes.

Is there a 'pex' way to avoid this, when building a venv out? Is it to exclude pex itself from the venv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants