Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upgrading to latest #15

Closed
jayvdb opened this issue Jun 12, 2019 · 3 comments · Fixed by #16
Closed

Allow upgrading to latest #15

jayvdb opened this issue Jun 12, 2019 · 3 comments · Fixed by #16
Milestone

Comments

@jayvdb
Copy link

jayvdb commented Jun 12, 2019

Now that this plugin supports tox-venv, it could be used to upgrade the pip inside the venv. See tox-dev/tox-venv#25 (comment) That isnt usually required, as tox without tox-venv will use virtualenv which does this upgrade automatically.

This might also be implemented as part of 'ranges' #12 , if it uses normal specifiers which can include >19, which will typically cause pip to install the latest.

@pglass
Copy link
Owner

pglass commented Jun 13, 2019

This should be addressed in #16. We'll be able to use pip_version = pip to install latest (equivalent to a pip install -U pip) or use pip_version = pip>=19.1 or similar.

@jayvdb
Copy link
Author

jayvdb commented Jun 14, 2019

I think this (upgrade to latest) needs to be possible with any extra dependencies inside the venv , such as the dependency on packaging in the venv.

@pglass
Copy link
Owner

pglass commented Jun 14, 2019

Yeah, please look closer at the PR. packaging is a dev/test dependency only.

@pglass pglass added this to the v0.0.5 milestone Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants