Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmppCore.IqRequest bug #54

Open
cimframe opened this issue Mar 12, 2017 · 0 comments
Open

XmppCore.IqRequest bug #54

cimframe opened this issue Mar 12, 2017 · 0 comments

Comments

@cimframe
Copy link

In testing vCard avatar updates, a bug was detected in the request response parsing.

The old code:

if (request.To.Domain == Jid.Domain && (request.To.Node == null || request.To.Node == "") && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

was replaced with:

if (request.To != null && request.To.Domain == Jid.Domain && string.IsNullOrEmpty (request.To.Node) && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

The fact that avatars are sent out to a PEP subscription, there is no TO! That fixes that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant