diff --git a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testHoldRequestedCritiquesWeak.st b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testHoldRequestedCritiquesWeak.st index 3018cdb0..3aa547fe 100644 --- a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testHoldRequestedCritiquesWeak.st +++ b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testHoldRequestedCritiquesWeak.st @@ -1,16 +1,17 @@ tests testHoldRequestedCritiquesWeak - | class result | + | class | + "by some reason analysisResult should be inst var. When it is temp then garbage collection not clean weak value of this variable when we nil it in the test. But it is cleaned when debugger is opened" self timeLimit: 10 seconds. class := ClyAnalyzedClassStub new. class foundClassCritiques: #(critique1 critique2). class passQuicklyCritiquesAnalysis. - result := critic analyze: class. + analysisResult := critic analyze: class. self waitAnalysisComplete. Smalltalk garbageCollect. - self assert: (critic requestedCritiques analysisResultFor: class ifAbsent: [ nil ]) == result. - result := nil. + self assert: (critic requestedCritiques analysisResultFor: class ifAbsent: [ nil ]) == analysisResult. + analysisResult := nil. Smalltalk garbageCollect. self deny: (critic requestedCritiques isRegistered: class). self assert: (critic requestedCritiques analysisResultFor: class ifAbsent: [ nil ]) isNil. diff --git a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testUpdatingAllCritiques.st b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testUpdatingAllCritiques.st index 91c4c9e7..c7a6c5f4 100644 --- a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testUpdatingAllCritiques.st +++ b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/instance/testUpdatingAllCritiques.st @@ -4,7 +4,7 @@ testUpdatingAllCritiques class := ClyAnalyzedClassStub new. class foundClassCritiques: (#critique1). class analyzedClassSideSelectors: #(methodWithHalt). - critic analyze: class. + analysisResult := critic analyze: class. self waitAnalysisComplete. self assert: (critic doesObjectHaveCritiques: ClyAnalyzedClassStub class >> #methodWithHalt). diff --git a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/properties.json b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/properties.json index 2a63fbc5..3c71600a 100644 --- a/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/properties.json +++ b/Calypso-Plugins-Critic-Environment-Tests.package/ClySystemCriticTests.class/properties.json @@ -6,7 +6,8 @@ "pools" : [ ], "classvars" : [ ], "instvars" : [ - "critic" + "critic", + "analysisResult" ], "name" : "ClySystemCriticTests", "type" : "normal" diff --git a/Calypso-Plugins-Critic-Environment.package/Behavior.extension/instance/computeCritiquesBy..st b/Calypso-Plugins-Critic-Environment.package/Behavior.extension/instance/computeCritiquesBy..st index dba68093..73bc47db 100644 --- a/Calypso-Plugins-Critic-Environment.package/Behavior.extension/instance/computeCritiquesBy..st +++ b/Calypso-Plugins-Critic-Environment.package/Behavior.extension/instance/computeCritiquesBy..st @@ -3,4 +3,5 @@ computeCritiquesBy: aSystemCritic aSystemCritic registerCritiques: self critiques for: self. - aSystemCritic analyze: (ClyAnalyzedClassMethods of: self) \ No newline at end of file + aSystemCritic analyze: (ClyAnalyzedClassMethods of: self) + \ No newline at end of file