Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/prototype Properties and fields from QuadrilateralModel.ts #342

Closed
jessegreenberg opened this issue Jan 30, 2023 · 2 comments
Assignees
Labels
meeting:a11y-team type:question Further information is requested

Comments

@jessegreenberg
Copy link
Contributor

Used by Tangible controller:

  • physicalModelBoundsProperty - used to map tangible sizes to vertex positions in sim
  • physicalToVirtualTransform - A general transform for mapping tangible vertex positions to sim positions
  • isCalibratingProperty - Showing the calibration dialog?

Used by Electron app:

  • showDebugValuesProperty - (Only observable because it could be shown/hidden from electron app)
  • tangibleRotationProperty - Was used in prototypes detecting tangible angle of rotation.

Properties related to OpenCV prototypes (#20 )

  • allVertexMarkersDetectedProperty
  • rotationMarkerDetectedProperty
  • vertexAMarkerDetectedProperty
  • vertexBMarkerDetectedProperty
  • vertexCMarkerDetectedProperty
  • vertexDMarkerDetectedProperty
  • markerResponsesEnabledProperty

General:

Also - get rid of window.simModel (allowed full model control from Electron or other wrappers).

@jessegreenberg
Copy link
Contributor Author

I guess the first thing we need to do is have a sense of what features are going to be saved for the prototypes page.

@jessegreenberg jessegreenberg added the type:question Further information is requested label Jan 30, 2023
@jessegreenberg
Copy link
Contributor Author

This code is being moved into a difference class and we can discuss this more in #301. CLosing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting:a11y-team type:question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant