Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HuggingFace Custom Embedder raises error when used with PDFUrlKnowledgeBase #1654

Open
DarkDk123 opened this issue Dec 29, 2024 · 4 comments · May be fixed by #1670
Open

HuggingFace Custom Embedder raises error when used with PDFUrlKnowledgeBase #1654

DarkDk123 opened this issue Dec 29, 2024 · 4 comments · May be fixed by #1670

Comments

@DarkDk123
Copy link

I was implementing a RAG with HuggingfaceCustomEmbedder and PDFUrlKnowledgeBase as follows:

image

It raises the following NotImplementedError while loading documents (maybe)

image

Maybe it's not implemented yet in HuggingFace Embedder

Huggingface Embedder calls the Base method, it raises Not implemented!

image
@ysolanky
Copy link
Contributor

Hello @DarkDk123 ! Thanks for raising this. The HF embedder needs an update and I will have a PR out shortly

@DarkDk123
Copy link
Author

Hello @DarkDk123 ! Thanks for raising this. The HF embedder needs an update and I will have a PR out shortly

If you allow, I can do it in 1-2 day, I want to do contributions.

@Mihir5557
Copy link

you can even use Gemini Embedding if you want free

@ysolanky
Copy link
Contributor

@DarkDk123 please go ahead. Looking forward to your PR

@DarkDk123 DarkDk123 linked a pull request Dec 31, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed HuggingFace Embedder #1654 DarkDk123/phidata
3 participants
@DarkDk123 @ysolanky @Mihir5557