Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fixed.py #1705

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update fixed.py #1705

merged 2 commits into from
Jan 7, 2025

Conversation

Gruhit13
Copy link
Contributor

@Gruhit13 Gruhit13 commented Jan 5, 2025

Ensure that the overlap value is always smaller than chunk_size to ensure smooth functioning.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

@Gruhit13
Update fixed.py
1f7013d 
Ensure that the overlap value is always smaller than chunk_size to ensure smooth functioning.
@manthanguptaa manthanguptaa merged commit 2e64aa5 into agno-agi:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthanguptaa manthanguptaa manthanguptaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gruhit13 @manthanguptaa