From 924c7e6e899d7c8c0a2f5ed5244b685b0a1c8aa8 Mon Sep 17 00:00:00 2001 From: "auto-submit[bot]" <98614782+auto-submit[bot]@users.noreply.github.com> Date: Thu, 28 Mar 2024 02:55:25 +0000 Subject: [PATCH] Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (#6419) Reverts: flutter/packages#6416 Initiated by: ditman Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue) https://github.com/flutter/flutter/issues/145866 Original PR Author: ditman Reviewed By: {jmagman} This change reverts the following previous change: Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!** --- script/tool/lib/src/podspec_check_command.dart | 1 - script/tool/test/podspec_check_command_test.dart | 4 ---- 2 files changed, 5 deletions(-) diff --git a/script/tool/lib/src/podspec_check_command.dart b/script/tool/lib/src/podspec_check_command.dart index d437e2188c1b5..b0982b7ee69e8 100644 --- a/script/tool/lib/src/podspec_check_command.dart +++ b/script/tool/lib/src/podspec_check_command.dart @@ -151,7 +151,6 @@ class PodspecCheckCommand extends PackageLoopingCommand { podspecPath, '--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices. '--skip-tests', - '--allow-warnings', '--use-modular-headers', // Flutter sets use_modular_headers! in its templates. if (libraryLint) '--use-libraries' ]; diff --git a/script/tool/test/podspec_check_command_test.dart b/script/tool/test/podspec_check_command_test.dart index 3bbe60b506c75..6745f18b6d4f3 100644 --- a/script/tool/test/podspec_check_command_test.dart +++ b/script/tool/test/podspec_check_command_test.dart @@ -156,7 +156,6 @@ void main() { .path, '--configuration=Debug', '--skip-tests', - '--allow-warnings', '--use-modular-headers', '--use-libraries' ], @@ -172,7 +171,6 @@ void main() { .path, '--configuration=Debug', '--skip-tests', - '--allow-warnings', '--use-modular-headers', ], packagesDir.path), @@ -214,7 +212,6 @@ void main() { .path, '--configuration=Debug', '--skip-tests', - '--allow-warnings', '--use-modular-headers', '--use-libraries' ], @@ -230,7 +227,6 @@ void main() { .path, '--configuration=Debug', '--skip-tests', - '--allow-warnings', '--use-modular-headers', ], packagesDir.path),