Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom error message when user has exceeded capacity #7424

Open
MauAraujo opened this issue Oct 4, 2022 · 0 comments
Open

Add custom error message when user has exceeded capacity #7424

MauAraujo opened this issue Oct 4, 2022 · 0 comments
Labels
feature New feature or request priority-5-low #5 Priority - Something that should happen eventually 📁 Repo: backend This PR/Issue modifies /backend code 📁 Repo: browser This PR/Issue modifies /browser code

Comments

@MauAraujo
Copy link

Feature Description
PR #7375 added a check and configurable parameter to the backend so that users can't start more mandelboxes than allowed. So, if the limit is exceeded, the backend responds with a 503 error and includes an error field in the response with the error code USER_ALREADY_ACTIVE

The Problem It Fixes
Currently, if the limit is exceeded, we display a generic error message that says "Our servers are at capacity".

We should display a more relevant error that indicates to the user that they have reached the limit of mandelboxes for that session.

Note: a mandelbox is started per profile, so it makes more sense to word the message as a profile limit.

Potential Implementation(s)
The extension already has code to handle error codes received in the response, so it's just a matter of adding another case and displaying the new message.

@MauAraujo MauAraujo added the 📁 Repo: browser This PR/Issue modifies /browser code label Oct 4, 2022
@philippemnoel philippemnoel added feature New feature or request priority-5-low #5 Priority - Something that should happen eventually 📁 Repo: backend This PR/Issue modifies /backend code labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request priority-5-low #5 Priority - Something that should happen eventually 📁 Repo: backend This PR/Issue modifies /backend code 📁 Repo: browser This PR/Issue modifies /browser code
Projects
None yet
Development

No branches or pull requests

2 participants